Fix nested PartialModel null detection for optional fields#3039
Merged
tyt2y3 merged 3 commits intoSeaQL:masterfrom Apr 8, 2026
Merged
Fix nested PartialModel null detection for optional fields#3039tyt2y3 merged 3 commits intoSeaQL:masterfrom
tyt2y3 merged 3 commits intoSeaQL:masterfrom
Conversation
WaterWhisperer
force-pushed
the
partial-model-null-detection
branch
from
f82b7d8 to
fdb8d3a
Compare
Huliiiiii
reviewed
Apr 6, 2026
Huliiiiii
force-pushed
the
partial-model-null-detection
branch
from
708e3c4 to
54870a6
Compare
Huliiiiii
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
Bug Fixes
DeriveModelnull detection for nested partial models when the nested model contains optional fields.a nested
Option<Model>loaded through a left join could incorrectly fail withMissing value for column 'id'if the nested model itself hadOption<T>fields.Breaking Changes
Changes
DeriveModelnull-check generation to account for nestedOptiondepthsea-ormandsea-orm-sync